aws - minor improvements

targets/aws/amazonmq/README.md

@@ -11,6 +11,7 @@ The following are required to run the AmazonMQ target connector:
 
 
 - Please note the connector uses connection with stomp+ssl, when finishing handling messages need to call Close().
+
 ## Configuration
 
 AmazonMQ target connector configuration properties:

targets/aws/athena/README.md

@@ -1,6 +1,6 @@
 # Kubemq athena target Connector
 
-Kubemq  athena target connector allows services using kubemq server to access aws athena service.
+Kubemq athena target connector allows services using kubemq server to access aws athena service.
 
 ## Prerequisites
 The following required to run the aws-dynamodb target connector:

targets/aws/cloudwatch/events/client_test.go

@@ -88,7 +88,7 @@ func TestClient_Init(t *testing.T) {
 		wantErr bool
 	}{
 		{
-			name: "init ",
+			name: "init",
 			cfg: config.Spec{
 				Name: "aws-cloudwatch-events",
 				Kind: "aws.cloudwatch.events",

targets/aws/cloudwatch/logs/client_test.go

@@ -26,7 +26,6 @@ type testStructure struct {
 	policyName     string
 	policyDocument string
 
-	limit         int64
 	sequenceToken string
 }
 
@@ -81,7 +80,6 @@ func getTestStructure() (*testStructure, error) {
 	}
 	t.sequenceToken = fmt.Sprintf("%s", dat)
 
-	t.limit = 10
 
 	return t, nil
 }

targets/aws/keyspaces/metadata.go

@@ -6,8 +6,8 @@ import (
 )
 
 const (
-	DefaultKey = ""
-	DefaultTable = ""
+	DefaultKey      = ""
+	DefaultTable    = ""
 	DefaultKeyspace = ""
 )
 
@@ -20,10 +20,10 @@ var methodsMap = map[string]string{
 }
 
 var consistencyMap = map[string]string{
-	"one":   "one",
-	"local_one": "local_one",
+	"one":          "one",
+	"local_one":    "local_one",
 	"local_quorum": "local_quorum",
-	"":         "",
+	"":             "",
 }
 
 type metadata struct {

targets/aws/keyspaces/options.go

@@ -13,19 +13,23 @@ const (
 	defaultReplicationFactor = 1
 	defaultConsistency       = gocql.LocalQuorum
 	defaultPort              = 9142
+	defaultUsername          = ""
+	defaultPassword          = ""
+	defaultKeyspace          = ""
+	defaultTable             = ""
 )
 
 type options struct {
-	hosts             []string
-	port              int
-	protoVersion      int
-	replicationFactor int
-	username          string
-	password          string
-	consistency       gocql.Consistency
-	defaultTable      string
-	defaultKeyspace   string
-	tls               string
+	hosts                 []string
+	port                  int
+	protoVersion          int
+	replicationFactor     int
+	username              string
+	password              string
+	consistency           gocql.Consistency
+	defaultTable          string
+	defaultKeyspace       string
+	tls                   string
 	timeoutSeconds        time.Duration
 	connectTimeoutSeconds time.Duration
 }
@@ -53,14 +57,14 @@ func parseOptions(cfg config.Spec) (options, error) {
 	if err != nil {
 		return options{}, fmt.Errorf("error parsing replication factor value, %w", err)
 	}
-	o.username = cfg.ParseString("username", "")
-	o.password = cfg.ParseString("password", "")
+	o.username = cfg.ParseString("username", defaultUsername)
+	o.password = cfg.ParseString("password", defaultPassword)
 	o.consistency, err = getConsistency(cfg.ParseString("consistency", "local_quorum"))
 	if err != nil {
 		return options{}, fmt.Errorf("error parsing consistency value, %w", err)
 	}
-	o.defaultTable = cfg.ParseString("default_table", "")
-	o.defaultKeyspace = cfg.ParseString("default_keyspace", "")
+	o.defaultTable = cfg.ParseString("default_table", defaultTable)
+	o.defaultKeyspace = cfg.ParseString("default_keyspace", defaultKeyspace)
 	connectTimeout, err := cfg.ParseIntWithRange("connect_timeout_seconds", 60, 1, math.MaxInt32)
 	if err != nil {
 		return options{}, fmt.Errorf("error parsing connect timeout seconds timeout value, %w", err)

targets/aws/lambda/README.md

@@ -11,7 +11,7 @@ The following required to run the aws-lambda target connector:
 
 ## Configuration
 
-sns target connector configuration properties:
+lambda target connector configuration properties:
 
 | Properties Key | Required | Description                                | Example                     |
 |:---------------|:---------|:-------------------------------------------|:----------------------------|

targets/aws/msk/metadata.go

@@ -10,6 +10,11 @@ import (
 	"github.com/kubemq-hub/kubemq-targets/types"
 )
 
+const (
+	defaultKey     = ""
+	defaultHeaders = ""
+)
+
 type metadata struct {
 	Headers []kafka.RecordHeader
 	Key     []byte
@@ -18,11 +23,11 @@ type metadata struct {
 func parseMetadata(meta types.Metadata, opts options) (metadata, error) {
 	m := metadata{}
 	var err error
-	err = m.parseHeaders(meta.ParseString("headers", ""))
+	err = m.parseHeaders(meta.ParseString("headers", defaultHeaders))
 	if err != nil {
 		return metadata{}, fmt.Errorf("error parsing headers, %w", err)
 	}
-	k := meta.ParseString("key", "")
+	k := meta.ParseString("key", defaultKey)
 	err = m.parseKey(k)
 	if err != nil {
 		return metadata{}, fmt.Errorf("error parsing Key, %w", err)

targets/aws/redshift/README.md

@@ -31,7 +31,7 @@ bindings:
       properties:
         host: "localhost"
         port: "50000"
-        client_id: "kubemq-query-aws-redshift-connector"
+        client_id: "kubemq-query-aws-redshift-connector-svc"
         auth_token: ""
         channel: "query.aws.redshift.service"
         group:   ""