fix: cancel delete staticroute when it's used by NatRule #1733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xujunjie-cover <[email protected]>
oilbeater
approved these changes
Jul 22, 2022
oilbeater
pushed a commit
that referenced
this pull request
Jul 22, 2022
Signed-off-by: xujunjie-cover <[email protected]> (cherry picked from commit f582a11)
oilbeater
pushed a commit
that referenced
this pull request
Jul 22, 2022
Signed-off-by: xujunjie-cover <[email protected]> (cherry picked from commit f582a11)
oilbeater
pushed a commit
that referenced
this pull request
Jul 22, 2022
Signed-off-by: xujunjie-cover <[email protected]> (cherry picked from commit f582a11)
oilbeater
requested changes
Jul 22, 2022
| @@ -647,6 +647,10 @@ func (c *Controller) gcStaticRoute() error { | |||
| for _, route := range routes { | |||
| if route.CIDR != "0.0.0.0/0" && route.CIDR != "::/0" && c.ipam.ContainAddress(route.CIDR) { | |||
| klog.Infof("gc static route %s %s %s", route.Policy, route.CIDR, route.NextHop) | |||
| exist, err := c.ovnLegacyClient.NatRuleExists(route.CIDR) | |||
There was a problem hiding this comment.
Just find some problem after merge. The logical should come before the klog.Infof("gc static route %s %s %s", route.Policy, route.CIDR, route.NextHop) and the err should be logged
There was a problem hiding this comment.
Sorry, It's my carelessness. I will create a new pr to repair it.
does err need to logged here? it already logged in c.ovnLegacyClient.NatRuleExists.
log twice or only log err here. which is better? @oilbeater
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gc will delete staticroute whice used by natrule.
Signed-off-by: xujunjie-cover [email protected]
What type of this PR
Examples of user facing changes:
Which issue(s) this PR fixes:
Fixes #1732