Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only support IPv4 snat in vpc-nat-gw when internal subnet is dual #1747

Merged
merged 1 commit into from
Jul 26, 2022

Conversation

hongzhen-ma
Copy link
Collaborator

@hongzhen-ma hongzhen-ma commented Jul 26, 2022

What type of this PR

  • Bug fixes

Which issue(s) this PR fixes:

Fixes #1657

@hongzhen-ma hongzhen-ma changed the title Nat gw only support IPv4 snat in vpc-nat-gw when internal subnet is dual Jul 26, 2022
@oilbeater oilbeater requested a review from bobz965 July 26, 2022 04:34
@bobz965
Copy link
Collaborator

bobz965 commented Jul 26, 2022

It looks good to me. @hongzhen-ma @oilbeater

Copy link
Collaborator

@bobz965 bobz965 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

@hongzhen-ma hongzhen-ma merged commit f735833 into master Jul 26, 2022
@hongzhen-ma hongzhen-ma deleted the nat-gw branch July 26, 2022 06:02
@hongzhen-ma
Copy link
Collaborator Author

回合了release-1.10 分支
release-1.9 分支,因为差异比较大,vpc 下的规则都是写在vpc-nat-gw spec 下的,没有单独的crd,不再往1.9 分支回合。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nat gw pod snat rule apply failed when subnet is dualstack
2 participants