release-1.8: do not check static route conflict #1817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangzujian
force-pushed
the
fix-route-1.8
branch
from
d382f29
to
2f44599
Compare
zhangzujian
changed the title
zhangzujian
requested review from
oilbeater
and removed request for
hongzhen-ma
hongzhen-ma
requested changes
Aug 16, 2022
| } | ||
| } | ||
|
|
||
| ports, err := c.ovnClient.ListPodLogicalSwitchPorts(podName, pod.Namespace) | ||
| ports, err := c.ovnClient.ListPodLogicalSwitchPorts(pod.Name, pod.Namespace) |
There was a problem hiding this comment.
这里要用 podName，vm 保留IP的时候，podName 是 vmName ，部署 vm pod name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of this PR
Which issue(s) this PR fixes:
Fixes #(issue-number)
Duplicate IP addresses will block LSP creation so there is no need to check static route conflict. This patch fixes the following error: