Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: delete fiprule failed at first time #1998

Merged
merged 1 commit into from
Oct 31, 2022
Merged

fix: delete fiprule failed at first time #1998

merged 1 commit into from
Oct 31, 2022

Conversation

shane965
Copy link
Contributor

@shane965 shane965 commented Oct 28, 2022 •
edited
Loading

What type of this PR

Examples of user facing changes:

  • Bug fixes

@shane965
Copy link
Contributor Author

shane965 commented Oct 28, 2022 •
edited by bobz965
Loading

When conntrack record doesn't exist, exit code is 1. We should ignore the exit code in this scene.

@bobz965
Copy link
Collaborator

bobz965 commented Oct 31, 2022

When conntrack record doesn't exist, exit code is 1. We should ignore the exit code in this scene.

LGTM！

@oilbeater oilbeater added bug Something isn't working need backport labels Oct 31, 2022
@oilbeater oilbeater merged commit 32f65f8 into kubeovn:master Oct 31, 2022
oilbeater pushed a commit that referenced this pull request Oct 31, 2022
@shane965 @oilbeater
fix: delete fiprule failed at first time (#1998)
1bf5fa9 
(cherry picked from commit 32f65f8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oilbeater oilbeater oilbeater approved these changes

Assignees
No one assigned
Labels
bug Something isn't working need backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shane965 @bobz965 @oilbeater