Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor e2e testing #2078

Merged
merged 14 commits into from
Dec 29, 2022
Merged

refactor e2e testing #2078

merged 14 commits into from
Dec 29, 2022

Conversation

zhangzujian
Copy link
Member

What type of this PR

  • Tests

Which issue(s) this PR fixes:

This is part of the work for #1883.

test/kube-ovn/framework/log.go Fixed Show fixed Hide fixed
test/kube-ovn/framework/log.go Fixed Show fixed Hide fixed
ginkgo.Fail(nowStamp()+": "+msg, skip)
}

var codeFilterRE = regexp.MustCompile(`/github.com/onsi/ginkgo/v2/`)

Check failure

Code scanning / CodeQL

Incomplete regular expression for hostnames

This regular expression has an unescaped dot before 'com', so it might match more hosts than expected when [the regular expression is used](1).
ginkgo.Fail(nowStamp()+": "+msg, skip)
}

var codeFilterRE = regexp.MustCompile(`/github.com/onsi/ginkgo/v2/`)

Check failure

Code scanning / CodeQL

Missing regular expression anchor

When this is used as a regular expression on a URL, it may match anywhere, and arbitrary hosts may come before or after it.
ginkgo.Fail(nowStamp()+": "+msg, skip)
}

var codeFilterRE = regexp.MustCompile(`/github.com/onsi/ginkgo/v2/`)

Check failure

Code scanning / CodeQL

Incomplete regular expression for hostnames

This regular expression has an unescaped dot before 'com', so it might match more hosts than expected when [the regular expression is used](1).
ginkgo.Fail(nowStamp()+": "+msg, skip)
}

var codeFilterRE = regexp.MustCompile(`/github.com/onsi/ginkgo/v2/`)

Check failure

Code scanning / CodeQL

Missing regular expression anchor

When this is used as a regular expression on a URL, it may match anywhere, and arbitrary hosts may come before or after it.
@zhangzujian zhangzujian changed the title refactor e2e testing - part 1 refactor e2e testing Dec 13, 2022

dual-stack-underlay-logical-gw-e2e:
installation-compatibility-test:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What cases does this job test

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test installation for k8s prior to v1.24.

The master label is no longer present on kubeadm control plane. For new clusters, the label 'node-role.kubernetes.io/master' will no longer be added to control plane nodes, only the label 'node-role.kubernetes.io/control-plane' will be added.

test/e2e/framework/docker/network.go Outdated Show resolved Hide resolved
test/e2e/framework/docker/network.go Outdated Show resolved Hide resolved
test/e2e/framework/docker/network.go Outdated Show resolved Hide resolved
test/e2e/framework/expect.go Outdated Show resolved Hide resolved
test/e2e/framework/iproute/iproute.go Outdated Show resolved Hide resolved
test/e2e/framework/subnet.go Show resolved Hide resolved
@zhangzujian
Copy link
Member Author

@oilbeater Please review.

@zhangzujian zhangzujian merged commit 1407eba into kubeovn:master Dec 29, 2022
@zhangzujian zhangzujian deleted the e2e branch December 29, 2022 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci refactor test automation tests
Projects
No open projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants