refactor ipam unit test #2126
Merged
refactor ipam unit test #2126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) check all ipam and subnet module's export api 2) add pod with multi nic case 3) refactor comment in api By() 4) check more items in struct ipam 5) add case update err subnet cidr
zhangzujian
reviewed
Dec 5, 2022
test/unittest/ipam/ipam.go
Outdated
Comment on lines
45
to
52
| By("invalid mask len > 32") | ||
| err := im.AddOrUpdateSubnet(subnetName, "1.1.1.1/64", v4Gw, nil) | ||
| Expect(err).Should(MatchError(ipam.ErrInvalidCIDR)) | ||
|
|
||
| By("invalid ip range") | ||
| err = im.AddOrUpdateSubnet(subnetName, "1.1.256.1/24", v4Gw, nil) | ||
| Expect(err).Should(MatchError(ipam.ErrInvalidCIDR)) | ||
| }) |
There was a problem hiding this comment.
Edge cases, such as prefix = 30/31/32/33/34, are needed.
zhangzujian
reviewed
Dec 7, 2022
| @@ -2,11 +2,14 @@ package ipam | |||
|
|
|||
| import ( | |||
| "fmt" | |||
| "math/rand" | |||
There was a problem hiding this comment.
The random source should be initialized.
zhangzujian
reviewed
Dec 7, 2022
test/unittest/ipam/ipam.go
Outdated
| @@ -33,52 +36,103 @@ var _ = Describe("[IPAM]", func() { | |||
| dualCIDR := fmt.Sprintf("%s,%s", ipv4CIDR, ipv6CIDR) | |||
| dualExcludeIPs := append(ipv4ExcludeIPs, ipv6ExcludeIPs...) | |||
|
|
|||
| // TODO test case use random ip and ipcidr, and input test data should seperate from test case | |||
zhangzujian
reviewed
Dec 7, 2022
test/unittest/ipam/ipam.go
Outdated
Comment on lines
540
to
541
| iprlist := ipam.IPRangeList{&ipr} | ||
| Expect(iprlist.Contains(ip1)).To(BeTrue()) |
zhangzujian
approved these changes
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of this PR
Examples of user facing changes:
Which issue(s) this PR fixes:
Fixes #(issue-number)