fix: sometimes allocate IPv6 address failed but there is available IP in V6FreeIPList #2132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangzujian
reviewed
Dec 6, 2022
pkg/ipam/ip.go
Outdated
| @@ -15,7 +16,7 @@ type IPRange struct { | |||
| } | |||
|
|
|||
| func (a IP) Equal(b IP) bool { | |||
| return a == b | |||
| return net.ParseIP(string(a)).Equal(net.ParseIP(string(b))) | |||
There was a problem hiding this comment.
Suggested change
| return net.ParseIP(string(a)).Equal(net.ParseIP(string(b))) | |
| return a == b || net.ParseIP(string(a)).Equal(net.ParseIP(string(b))) |
There was a problem hiding this comment.
Where is Equal() used? Is there any chance that net.ParseIP(string(a)) may return nil?
There was a problem hiding this comment.
in splitIPRangeList, the equal function will return false
There was a problem hiding this comment.
for example, ipr.End = "fd00::e9:ed1" and ip ="fd00::00e9:0ed1"
…ress return NoAvailableAddress when use ipam.GetStaticAddress with param ipv6 address without clean Zero such as "fd00::00e9:0ed1", and exactly subnet.V6FreeIPList has a range with start fd00::e9:ed1 and end with any v6 address,or start with an any v6 address and end with fd00::e9:ed1, it will cause ipr.Start.Equal(ip) or ipr.End.Equal(ip) failed, and no v6 address allocated
changluyi
force-pushed
the
fix_alloc_ipv6_address_NoAvailableAddress
branch
from
09dbd4f
to
7f3a9ea
Compare
zhangzujian
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sometimes ipam.GetStaticAddress return NoAvailableAddress but there is available IP in V6FreeIPList
when use ipam.GetStaticAddress with param ipv6 address without clean Zero such as "fd00::00e9:0ed1", and exactly subnet.V6FreeIPList has a range with start fd00::e9:ed1 and end with any v6 address, or start with an any v6 address and end with fd00::e9:ed1, it will cause ipr.Start.Equal(ip) or ipr.End.Equal(ip) failed, Because equal only check the string match .
What type of this PR
Examples of user facing changes:
Which issue(s) this PR fixes:
Fixes #(issue-number)