feature: detect ipv4 address conflict in underlay #2208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| mac, err := util.ArpDetectIPConflict(link, ip, macAddr) | ||
| if err != nil { | ||
| err = fmt.Errorf("failed to detect address conflict for %s on link %s: %v", ip, link, err) | ||
| klog.Error(err) |
Check failure
Code scanning / CodeQL
Log entries created from user input
zhangzujian
force-pushed
the
ipv4-conflict-detection
branch
from
5bd7954
to
1c33b12
Compare
zhangzujian
force-pushed
the
ipv4-conflict-detection
branch
from
b99c217
to
8ba57b0
Compare
changluyi
approved these changes
Jan 4, 2023
zhangzujian
added a commit
that referenced
this pull request
Jan 4, 2023
zhangzujian
added a commit
that referenced
this pull request
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of this PR
Which issue(s) this PR fixes:
Fixes #2031