fix: when give ipv4 cidr ipv6 gateway, the gateway will extend infini… #3860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tely Signed-off-by: Changlu Yi <[email protected]>
hongzhen-ma
approved these changes
Mar 23, 2024
| @@ -428,7 +428,7 @@ func checkAndUpdateGateway(subnet *kubeovnv1.Subnet) (bool, error) { | |||
| switch { | |||
| case subnet.Spec.Gateway == "": | |||
| gw, err = util.GetGwByCidr(subnet.Spec.CIDRBlock) | |||
| case util.CheckProtocol(subnet.Spec.Gateway) != util.CheckProtocol(subnet.Spec.CIDRBlock): | |||
| case subnet.Spec.Protocol == kubeovnv1.ProtocolDual && util.CheckProtocol(subnet.Spec.Gateway) != util.CheckProtocol(subnet.Spec.CIDRBlock): | |||
There was a problem hiding this comment.
这里用到了subnet.Spec.Protocol 的取值，所以 formatSubnet 中 subnet.Spec.Protocol 的检查和赋值，最好放在 checkSubnetChanged 之前，保证这里使用的时候，是正确的 protocol 取值
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tely
Pull Request
What type of this PR
repeat steps:
Examples of user facing changes:
Which issue(s) this PR fixes
Fixes #(issue-number)