Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix lsp not updated correctly when logical switch is changed #4015

Merged
merged 2 commits into from
May 14, 2024
Merged

fix lsp not updated correctly when logical switch is changed #4015

merged 2 commits into from
May 14, 2024

Conversation

zhangzujian
Copy link
Member

@zhangzujian zhangzujian commented May 13, 2024 •
edited
Loading

Pull Request

What type of this PR

  • Bug Fix
  • Tests

Which issue(s) this PR fixes

  1. Create a VM and wait for it to be running;
  2. Stop the VM;
  3. Change the subnet assigned to the namespace;
  4. Start the VM.

In step 4, the VM cannot start since the LSP is not deleted in step 2 while the logical switch has been changed.

This PR also adds e2e test cases for:

  1. bug fixed by this PR;
  2. bug reported and fixed in fix lsp not updating addresses #4011.

@zhangzujian zhangzujian added the test automation tests label May 13, 2024
@zhangzujian zhangzujian marked this pull request as ready for review May 13, 2024 08:07
@zhangzujian zhangzujian requested review from oilbeater and removed request for oilbeater May 13, 2024 08:07
@zhangzujian zhangzujian marked this pull request as draft May 13, 2024 08:57
@zhangzujian zhangzujian force-pushed the add-e2e-tests branch 3 times, most recently from 3f51a01 to f874acc Compare May 14, 2024 04:57
@zhangzujian zhangzujian added bug Something isn't working need backport labels May 14, 2024
@zhangzujian zhangzujian changed the title add e2e test cases fix lsp not updated correctly when logical switch is changed May 14, 2024
@zhangzujian zhangzujian marked this pull request as ready for review May 14, 2024 05:35
@zhangzujian zhangzujian merged commit b8d77e2 into kubeovn:master May 14, 2024
62 checks passed
@zhangzujian zhangzujian deleted the add-e2e-tests branch May 14, 2024 08:03
zhangzujian added a commit that referenced this pull request May 14, 2024
@zhangzujian
fix lsp not updated correctly when logical switch is changed (#4015)
2e700ad 
Signed-off-by: zhangzujian <[email protected]>
bobz965 pushed a commit that referenced this pull request May 15, 2024
@zhangzujian @bobz965
fix lsp not updated correctly when logical switch is changed (#4015)
9d5c556 
Signed-off-by: zhangzujian <[email protected]>
@patriziobassi patriziobassi mentioned this pull request Nov 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oilbeater oilbeater oilbeater approved these changes

Assignees
No one assigned
Labels
bug Something isn't working need backport test automation tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhangzujian @oilbeater