fix: add ip_reserved label for vip #4093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zcq98 <[email protected]>
bobz965
approved these changes
May 28, 2024
bobz965
pushed a commit
that referenced
this pull request
May 28, 2024
Signed-off-by: zcq98 <[email protected]>
bobz965
pushed a commit
that referenced
this pull request
May 28, 2024
Signed-off-by: zcq98 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What type of this PR
Examples of user facing changes:
Which issue(s) this PR fixes
当更新VIP的CR时，若label为空则添加ovn.kubernetes.io/subnet和ovn.kubernetes.io/ip_reserved两个label，但是如果有其它label，则只会更新ovn.kubernetes.io/subnet的label，而不会再添加ovn.kubernetes.io/ip_reserved这个label，导致subnet统计usingIPs未能统计vip的数量。
