fix: set dhcp gateway to U2OInterconnectionIP when enabling dhcp and u2o #4228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangzujian
reviewed
Jun 26, 2024
|
We need an e2e test case. |
zcq98
force-pushed
the
u2o-dhcp
branch
2 times, most recently
from
9f6ee92
to
5055bec
Compare
bobz965
reviewed
Jul 1, 2024
bobz965
approved these changes
Jul 2, 2024
zhangzujian
reviewed
Jul 2, 2024
zhangzujian
approved these changes
Jul 2, 2024
Signed-off-by: zcq98 <[email protected]>
Signed-off-by: zcq98 <[email protected]>
Co-authored-by: 张祖建 <[email protected]> Signed-off-by: zcq98 <[email protected]>
zhangzujian
added a commit
to zhangzujian/kube-ovn
that referenced
this pull request
Jul 11, 2024
…u2o (kubeovn#4228) Signed-off-by: zcq98 <[email protected]> Co-authored-by: 张祖建 <[email protected]> Signed-off-by: zhangzujian <[email protected]>
bobz965
pushed a commit
that referenced
this pull request
Jul 22, 2024
…u2o (#4228) * fix: set dhcp gateway to U2OInterconnectionIP when enabling dhcp and u2o Signed-off-by: zcq98 <[email protected]> * add e2e for dhcp gateway check when enabling u2o Signed-off-by: zcq98 <[email protected]> * Update test/e2e/kube-ovn/underlay/underlay.go Co-authored-by: 张祖建 <[email protected]> Signed-off-by: zcq98 <[email protected]> --------- Signed-off-by: zcq98 <[email protected]> Co-authored-by: 张祖建 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What type of this PR
Examples of user facing changes:
Which issue(s) this PR fixes
Fixes #4224