[bugfix] Unable to correctly gc port group #4694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:M
|
@cmdy Hi, please fix the DCO. use |
Signed-off-by: cmdy <[email protected]>
cmdy
force-pushed
the
fix-gc-port_group
branch
from
399db11
to
4e32e0d
Compare
Hi, I find that the check task failed. What should I do to merge the code? Please review my code. |
bobz965
approved these changes
Nov 6, 2024
|
@cmdy Does master has the same issue? would you please help to fix it too? |
Okay, I'd be happy to. you can assign it to me. |
oilbeater
approved these changes
Nov 11, 2024
|
Thanks! @cmdy |
1 task
oilbeater
added a commit
that referenced
this pull request
Nov 13, 2024
This reverts commit c328da4.
oilbeater
added a commit
that referenced
this pull request
Nov 14, 2024
This reverts commit c328da4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What type of this PR
Examples of user facing changes:
Which issue(s) this PR fixes
EnableNPis not enabled, cannot gc node and subnet port group