Adds new flag --metrics-host (#811)

* Replaces flag --metrics-port with --metrics-addresss

Signed-off-by: Nathan Kinkade <[email protected]>

* Revert "Replaces flag --metrics-port with --metrics-addresss"

This reverts commit 528c7bb.

Signed-off-by: Nathan Kinkade <[email protected]>

* Adds new --metrics-host flag

The flag --metrics-port already exists. While not as clean, to avoid
introducing a backward incompatible change to flags, this commit adds a
new --metrics-host flag, which in combination with the existing
--metrics-port flag can define a complete listen address for the metrics
server as "<metrics-host>:<metrics-port>"

Signed-off-by: Nathan Kinkade <[email protected]>

* Adds new, commented flags --metrics-{port,host}

Signed-off-by: Nathan Kinkade <[email protected]>

---------

Signed-off-by: Nathan Kinkade <[email protected]>

cmd/kured/main.go

@@ -47,6 +47,7 @@ var (
 	drainTimeout                    time.Duration
 	rebootDelay                     time.Duration
 	period                          time.Duration
+	metricsHost                     string
 	metricsPort                     int
 	drainGracePeriod                int
 	drainPodSelector                string
@@ -126,6 +127,8 @@ func NewRootCommand() *cobra.Command {
 		"node name kured runs on, should be passed down from spec.nodeName via KURED_NODE_ID environment variable")
 	rootCmd.PersistentFlags().BoolVar(&forceReboot, "force-reboot", false,
 		"force a reboot even if the drain fails or times out")
+	rootCmd.PersistentFlags().StringVar(&metricsHost, "metrics-host", "",
+		"host where metrics will listen")
 	rootCmd.PersistentFlags().IntVar(&metricsPort, "metrics-port", 8080,
 		"port number where metrics will listen")
 	rootCmd.PersistentFlags().IntVar(&drainGracePeriod, "drain-grace-period", -1,
@@ -844,5 +847,5 @@ func root(cmd *cobra.Command, args []string) {
 	go maintainRebootRequiredMetric(nodeID, hostSentinelCommand)
 
 	http.Handle("/metrics", promhttp.Handler())
-	log.Fatal(http.ListenAndServe(fmt.Sprintf(":%d", metricsPort), nil))
+	log.Fatal(http.ListenAndServe(fmt.Sprintf("%s:%d", metricsHost, metricsPort), nil))
 }

kured-ds.yaml

@@ -83,3 +83,5 @@ spec:
 #            - --annotate-nodes=false
 #            - --lock-release-delay=30m
 #            - --log-format=text
+#            - --metrics-host=""
+#            - --metrics-port=8080