-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enterprise Linux Sentinel Command seems bugged. #498
Comments
Hi @alb-dev,
If there are problems with config-parameters or commands this is visible in the logs. Kured only executes the given commands as is with "nsenter" https://github.com/weaveworks/kured/blob/96bf7c1addef0b31ec6c8ab49e927480f0c337e7/cmd/kured/main.go#L260-L269 |
Hey @ckotzbauer Kubernetes version: 1.23.1+k3s2
|
Thanks @alb-dev for the details. |
I guess the command is working correctly @ckotzbauer as the kernel is up to date and the return code is 0. What i dont understand is why the sentinel command is executed very minute instead of once an hour and why start and endtime are ignored. Thanks for the support! |
Okay.
|
Hello Yeah no Problem. Because of the new 5.1 cve a kernel update was release which may help with testing.
The kernel update is register from "needs-restarting" which is returning eh exit code 1 if a a reboot is required. Neither 0 nor 1 is triggering a reboot at the moment. |
Hm, as the time in the logs is |
I will try to build a wrapper output so that only 1 or 0 is returned. Maybe this will work for EL Distros. |
Would something as simple as this wrapper script be sufficient? I'm about to deploy kured to a fedora based cluster and stumbled upon this open issue during my research.
|
I've tried the following config (and other combinations) but it doesn't seem to work: configuration:
rebootSentinelCommand: 'sh -c "! needs-restarting --reboothint"'
Running the command manually on the host returns
And same return code if I run it with
If I remove
|
My bad I need to wait for about an hour. The following config in configuration:
rebootSentinelCommand: 'sh -c "! needs-restarting --reboothint"' |
Nice. I build a cron wrapper which create the reboot-required file which is kinda a dirty. I like your solution. Maybe this could be added to the docs? |
Sure, I've created a PR. |
Looks like the issue still exists for redhat (Red Hat Enterprise Linux release 8.8 (Ootpa). The configuration tested were :
default period is used for the values.
logs from worker node:
|
Where do you add the
|
Hello,
right now i am testing a k3s cluster with rocky linux 8.5. I deployed kured via helm chart with following configuration
It seems like "period", "startTime" and "endTime" are ignored.
Beside that it looks like dnf-util's "needs-restarting -r" is not properly registered. Is something wrong with my implementation?
Best regards
alb
The text was updated successfully, but these errors were encountered: