-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add sentinel command example for RHEL family #504
Conversation
|
||
```yaml | ||
configuration: | ||
rebootSentinelCommand: sh -c "! needs-restarting --reboothint" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has there been thorough testing that this works without escaping quotes? This is definitely valid yaml, but the dispatch of this string includes a few stops along the way until it gets to the actual host OS as a command string, wanna make sure we're good here.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, Helm still creates the same output YAML with or without quotes:
# ...
command:
- /usr/bin/kured
args:
- --ds-name=release-name-kured
- --ds-namespace=default
- --reboot-sentinel-command=sh -c "! needs-restarting --reboothint"
- --reboot-command=/bin/systemctl reboot
- --log-format=text
# ...
I've tested both in my homelab
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Looks great. This will save people some trial and error time. Not to derail, but has anyone else tried something like |
I don't have a cluster with mixed distros so I can't test that, therefore it won't be included in this PR, but in theory it should work. |
while i single quoted the string for safety the command worked perfectly for me on fedora 35 |
Add example for RHEL.
Fixes #498