removed notifications/slack package [Merge after 1.7.0 release] #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atighineanu
changed the title
atighineanu
changed the title
|
Look at all this red (in commit diff), and all this green (in CI). I vote for that! |
dholbach
reviewed
Jun 23, 2021
evrardjp
previously requested changes
Jul 28, 2021
|
This PR was automatically considered stale due to lack of activity. Please refresh it and/or join our slack channels to highlight it, before it automatically closes (in 7 days). |
atighineanu
force-pushed
the
proto_removed_slack
branch
from
5eafd79
to
72df1d8
Compare
|
|
That diff looks good. I will have a view in more details soon. |
atighineanu
force-pushed
the
proto_removed_slack
branch
4 times, most recently
from
9a5f281
to
2588b6c
Compare
In this PR the slack-hook-url is translated into shoutrrr syntax. Therefore, slack pack age as well as checks for slack-hook-url in drain and reboot functions are removed. Also added a unit test for flagCheck(), this function also checks the (slack)URL syntax.
atighineanu
force-pushed
the
proto_removed_slack
branch
from
2588b6c
to
bab1425
Compare
|
@evrardjp Are you happy with this now? |
|
Revisited this PR, it looks good for merge from my perspective. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR the slack-hook-url is translated
into shoutrrr syntax. Therefore, slack pack
age as well as checks for slack-hook-url in
drain and reboot functions are removed.
I suppose we will keep the --slack-hook-url for an undefined amount of releases. Therefore, I kept it while I got rid of the notifications/slack package.