-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added notification when uncordoning #587
Conversation
when reboot & uncordoning is succ essful -> notification will be se nt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
That looks good, thanks. I just would propose to introduce a message-template parameter as we have it already for the other notifications to stay in sync. |
added message template for announcing successful uncor- doning and reboot.
@ckotzbauer |
@ckotzbauer thanks for making this PR even better :) |
Thanks for the readme change @atighineanu. |
DONE |
954db8c
to
bd1d84f
Compare
added readme note about new flag
when reboot & uncordoning is successful -> notification will be sent.
Fixes: #585
AFTER: