Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added notification when uncordoning #587

Merged
merged 3 commits into from
Jun 25, 2022
Merged

added notification when uncordoning #587

merged 3 commits into from
Jun 25, 2022

Conversation

atighineanu
Copy link
Contributor

when reboot & uncordoning is successful -> notification will be sent.
Fixes: #585

AFTER:

[kured-bot](https://app.slack.com/team)
APP  
[1:26 PM](https://kured-tesing-personal.slack.com/archives)
Draining node kind-worker2
[1:26](https://kured-tesing-personal.slack.com/archives)
Rebooting node kind-worker2
[1:27](https://kured-tesing-personal.slack.com/archives)
Node: kind-worker2 rebooted&uncordoned successfully!

@atighineanu atighineanu mentioned this pull request Jun 24, 2022
Closed
jackfrancis
jackfrancis reviewed Jun 24, 2022
View reviewed changes
cmd/kured/main.go Outdated Show resolved Hide resolved
@atighineanu
added notification when uncordoning
e01ed7b 
 when reboot & uncordoning is succ
 essful -> notification will be se
 nt
jackfrancis
jackfrancis approved these changes Jun 24, 2022
View reviewed changes
Copy link
Collaborator

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ckotzbauer
Copy link
Member

That looks good, thanks. I just would propose to introduce a message-template parameter as we have it already for the other notifications to stay in sync.

@atighineanu
added uncordon message tmpl
1d1a1df 
 added message template for
 announcing successful uncor-
 doning and reboot.
@atighineanu
Copy link
Contributor Author

@ckotzbauer
AFTER:
kured-bot
APP 2:00 PM
Draining node kind-worker
2:00
Rebooting node kind-worker
New
2:02
Node kind-worker rebooted & uncordoned successfully!

@ckotzbauer
Copy link
Member

Great, thanks for the flag.
Can you please add it to the README here and here as well? Then I'm finally happy 😆

@atighineanu
Copy link
Contributor Author

Great, thanks for the flag. Can you please add it to the README here and here as well? Then I'm finally happy laughing

Done.
Readme, and charts/values as well.

@jackfrancis
Copy link
Collaborator

@ckotzbauer thanks for making this PR even better :)

@ckotzbauer
Copy link
Member

Thanks for the readme change @atighineanu.
Sorry again, but can we do the chart-values change in a separate PR? We have to split chart- and non-chart-changes due to the release-process.

@atighineanu
Copy link
Contributor Author

Thanks for the readme change @atighineanu. Sorry again, but can we do the chart-values change in a separate PR? We have to split chart- and non-chart-changes due to the release-process.

DONE

@atighineanu
added proper documentation about new flag
57479b8 
 added readme note about new flag
@ckotzbauer ckotzbauer merged commit 28c5332 into kubereboot:main Jun 25, 2022
@ckotzbauer ckotzbauer mentioned this pull request Jul 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackfrancis jackfrancis jackfrancis approved these changes

@ckotzbauer ckotzbauer ckotzbauer approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(Optionally?) Notify when node is up and running again
3 participants
@atighineanu @ckotzbauer @jackfrancis