Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build with golang 1.12 and modules #74

Merged
merged 4 commits into from
May 16, 2019
Merged

Build with golang 1.12 and modules #74

merged 4 commits into from
May 16, 2019

Conversation

awh
Copy link
Contributor

@awh awh commented May 16, 2019 •
edited
Loading

The dependencies in go.mod exactly match those in the removed Gopkg.lock.

bboreham
bboreham approved these changes May 16, 2019
View reviewed changes
Copy link
Contributor

@bboreham bboreham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit

@awh awh merged commit 26e1ab8 into master May 16, 2019
@awh awh deleted the go-modules branch May 16, 2019 15:07
@dholbach dholbach added this to the 1.3.0 milestone Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bboreham bboreham bboreham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@awh @bboreham @dholbach