Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds new flag --metrics-host #811

Merged
merged 4 commits into from
Aug 8, 2023
Merged

Adds new flag --metrics-host #811

merged 4 commits into from
Aug 8, 2023

Commits on Aug 3, 2023

  1. Replaces flag --metrics-port with --metrics-addresss 

    Signed-off-by: Nathan Kinkade <[email protected]>
    @nkinkade
    nkinkade committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    528c7bb View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2023

  1. Revert "Replaces flag --metrics-port with --metrics-addresss" 

    This reverts commit 528c7bb.

Signed-off-by: Nathan Kinkade <[email protected]>
    @nkinkade
    nkinkade committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    955b79d View commit details
    Browse the repository at this point in the history

  2. Adds new --metrics-host flag 

    The flag --metrics-port already exists. While not as clean, to avoid
introducing a backward incompatible change to flags, this commit adds a
new --metrics-host flag, which in combination with the existing
--metrics-port flag can define a complete listen address for the metrics
server as "<metrics-host>:<metrics-port>"

Signed-off-by: Nathan Kinkade <[email protected]>
    @nkinkade
    nkinkade committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    f04db81 View commit details
    Browse the repository at this point in the history

  3. Adds new, commented flags --metrics-{port,host} 

    Signed-off-by: Nathan Kinkade <[email protected]>
    @nkinkade
    nkinkade committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    e5d94c4 View commit details
    Browse the repository at this point in the history