Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix etcd init on cluster with more then 1 interface #160

Merged
merged 1 commit into from
Jan 10, 2019

Conversation

kron4eg
Copy link
Member

@kron4eg kron4eg commented Jan 10, 2019

What this PR does / why we need it:
Fix etcd init on 3rd node in cluster on machines with more the 1 network interface.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Documentation:

Release note:

NONE

@kubermatic-bot kubermatic-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 10, 2019
@kron4eg
Copy link
Member Author

kron4eg commented Jan 10, 2019

/assign @xmudrii

@xmudrii
Copy link
Member

xmudrii commented Jan 10, 2019

Looks great!

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4a5a3654aec98c0c06ffa236666487dabbac4af6

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2019
@kubermatic-bot kubermatic-bot merged commit 5c2230a into master Jan 10, 2019
@kubermatic-bot kubermatic-bot deleted the fix-etcd-init branch January 10, 2019 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants