Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add openstack worker support #209

Merged
merged 2 commits into from
Mar 4, 2019
Merged

Conversation

mrIncompetent
Copy link
Contributor

@mrIncompetent mrIncompetent commented Feb 20, 2019

What this PR does / why we need it:
Adds worker node support for OpenStack.
This is just the work i did in January, but i'm not working on it anymore.
If someone want's to take over, feel free.

If a testing "script" with credentials is required, reach out to me.

Release note:

TBD

@kubermatic-bot kubermatic-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 20, 2019
@kron4eg kron4eg force-pushed the add-openstack-worker-support branch from e8c9ce8 to 6b027a9 Compare March 4, 2019 16:20
@kron4eg kron4eg changed the title [WIP] add openstack worker support add openstack worker support Mar 4, 2019
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 4, 2019
@kron4eg
Copy link
Member

kron4eg commented Mar 4, 2019

@xmudrii I'd like to merge this it order to not allow this to rot and departure far away from master and raise merge problems at later times. WDYT?

@xmudrii
Copy link
Member

xmudrii commented Mar 4, 2019

@kron4eg Sounds good to me

@kron4eg
Copy link
Member

kron4eg commented Mar 4, 2019

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fff275fc8efad4f62c30a1d4f0bfa26a653e27e9

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2019
@kubermatic-bot kubermatic-bot merged commit 6f09397 into master Mar 4, 2019
@kubermatic-bot kubermatic-bot deleted the add-openstack-worker-support branch March 4, 2019 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants