Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade MachineDeployments #214

Merged
merged 3 commits into from
Feb 26, 2019
Merged

Upgrade MachineDeployments #214

merged 3 commits into from
Feb 26, 2019

Conversation

kron4eg
Copy link
Member

@kron4eg kron4eg commented Feb 25, 2019

Fixes #197

* new flag `--upgrade-machine-deployments`

@kubermatic-bot kubermatic-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 25, 2019
@kron4eg kron4eg force-pushed the 197-upgrade-machine-deployments branch from a58301d to 1328735 Compare February 25, 2019 17:07
@kron4eg
Copy link
Member Author

kron4eg commented Feb 26, 2019

/test pull-kubeone-e2e

@kdomanski kdomanski mentioned this pull request Feb 26, 2019
Closed
11 tasks
@kron4eg kron4eg force-pushed the 197-upgrade-machine-deployments branch from 1328735 to db73875 Compare February 26, 2019 15:47
@kron4eg kron4eg changed the title [WIP] Upgrade MachineDeployments Upgrade MachineDeployments Feb 26, 2019
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 26, 2019
@kron4eg kron4eg requested a review from xmudrii February 26, 2019 16:15
@kron4eg
Copy link
Member Author

kron4eg commented Feb 26, 2019

/assign @xmudrii

@kron4eg
Copy link
Member Author

kron4eg commented Feb 26, 2019

/retest

1 similar comment
@kron4eg
Copy link
Member Author

kron4eg commented Feb 26, 2019

/retest

xmudrii
xmudrii approved these changes Feb 26, 2019
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d8028b8b97d6b093b003c68bd21b0248d43bf72a

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 26, 2019
@kubermatic-bot kubermatic-bot merged commit d585b9d into master Feb 26, 2019
@kubermatic-bot kubermatic-bot deleted the 197-upgrade-machine-deployments branch February 26, 2019 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

Assignees

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kron4eg @kubermatic-bot @xmudrii