Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename EnableExternalCloudControllerManager -> External in ProviderConfig #237

Merged
merged 3 commits into from
Mar 6, 2019
Merged

Rename EnableExternalCloudControllerManager -> External in ProviderConfig #237

merged 3 commits into from
Mar 6, 2019

Conversation

kron4eg
Copy link
Member

@kron4eg kron4eg commented Mar 6, 2019

What this PR does / why we need it:
It makes more sense to name it like this, as all it does is add --cloud-provider=external to control plain component's flags

NONE

/assign @xmudrii

@kubermatic-bot kubermatic-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 6, 2019
xmudrii
xmudrii reviewed Mar 6, 2019
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update config.yaml.dist with recently added fields and add comments how they work? I think the example manifest has not been updated for some time now.

@kubermatic-bot kubermatic-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 6, 2019
xmudrii
xmudrii reviewed Mar 6, 2019
View reviewed changes
config.yaml.dist Outdated Show resolved Hide resolved
@xmudrii
Copy link
Member

xmudrii commented Mar 6, 2019

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 61d5b76e0e5629e18ec43b692234db0472b0c546

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2019
@kubermatic-bot kubermatic-bot merged commit cf2b9c4 into master Mar 6, 2019
@kubermatic-bot kubermatic-bot deleted the external_rename branch March 6, 2019 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii left review comments

Assignees

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kron4eg @xmudrii @kubermatic-bot