Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubeone reset --destroy-workers default true #252

Merged
merged 1 commit into from
Mar 12, 2019
Merged

Conversation

kron4eg
Copy link
Member

@kron4eg kron4eg commented Mar 12, 2019

What this PR does / why we need it:
Cleanup workers in reset clusters

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #250

kubeone reset will destroy workers by default

@kron4eg kron4eg requested a review from xmudrii March 12, 2019 12:04
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 12, 2019
@xmudrii
Copy link
Member

xmudrii commented Mar 12, 2019

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 12, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 404f1c5e9139c5d8fcc717241ff03a81d7b86638

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 12, 2019
@xmudrii
Copy link
Member

xmudrii commented Mar 12, 2019

/retest

@kubermatic-bot kubermatic-bot merged commit 6216f42 into master Mar 12, 2019
@kubermatic-bot kubermatic-bot deleted the 250-reset branch March 12, 2019 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reset left abandoned workers
3 participants