Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Openstack fixes #253

Merged
merged 1 commit into from
Mar 13, 2019
Merged

Openstack fixes #253

merged 1 commit into from
Mar 13, 2019

Conversation

kron4eg
Copy link
Member

@kron4eg kron4eg commented Mar 12, 2019 

NONE

@kubermatic-bot kubermatic-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 12, 2019
@kron4eg kron4eg changed the title [WIP] Openstack fixes Openstack fixes Mar 13, 2019
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 13, 2019
@kron4eg
Copy link
Member Author

kron4eg commented Mar 13, 2019

/test pull-kubeone-e2e-upgrade-digitalocean

@xmudrii
Copy link
Member

xmudrii commented Mar 13, 2019

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 13, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: dd58ba7efab94dc37e084bf03a84a9a3ead2abb8

@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 13, 2019
@mrIncompetent
Copy link
Contributor

/approve

@mrIncompetent
Copy link
Contributor

At least i tried :P

@xmudrii
Copy link
Member

xmudrii commented Mar 13, 2019

/approve

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrIncompetent, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 13, 2019
@xmudrii
Copy link
Member

xmudrii commented Mar 13, 2019

It lost lgtm along the way
/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 13, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2a2f74d436beb6259bd681fae812f77c684332fd

@kubermatic-bot kubermatic-bot merged commit ee863bd into master Mar 13, 2019
@kubermatic-bot kubermatic-bot deleted the openstack-fixes branch March 13, 2019 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvaroaleman alvaroaleman Awaiting requested review from alvaroaleman

@mrIncompetent mrIncompetent Awaiting requested review from mrIncompetent

@xmudrii xmudrii Awaiting requested review from xmudrii

Assignees

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kron4eg @xmudrii @kubermatic-bot @mrIncompetent