Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new features.enable_dynamic_audit_log #261

Merged
merged 1 commit into from
Mar 13, 2019
Merged

new features.enable_dynamic_audit_log #261

merged 1 commit into from
Mar 13, 2019

Conversation

kron4eg
Copy link
Member

@kron4eg kron4eg commented Mar 13, 2019

Fixes #229

add DynamicAuditing switch

@kron4eg kron4eg requested a review from xmudrii March 13, 2019 12:53
@kubermatic-bot kubermatic-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Mar 13, 2019
@kron4eg kron4eg requested a review from kdomanski March 13, 2019 12:53
@kubermatic-bot kubermatic-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 13, 2019
@xmudrii
Copy link
Member

xmudrii commented Mar 13, 2019

/lgtm
Leaving it open for some time if @kdomanski wants to take a look

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 13, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 29b1fc1549e9e96da408228e296c6e224b8557ba

@xmudrii
Copy link
Member

xmudrii commented Mar 13, 2019

/test pull-kubeone-e2e-upgrade-digitalocean

kdomanski
kdomanski reviewed Mar 13, 2019
View reviewed changes
pkg/features/activate.go
if clusterConfig.APIServer.ExtraArgs == nil {
clusterConfig.APIServer.ExtraArgs = make(map[string]string)
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's moved down to specific functions, in order to not initialize empty map in case if it's not needed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, now I see it's just moved.

@kdomanski
Copy link
Contributor

/approve

@kron4eg kron4eg added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 13, 2019
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: kdomanski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot merged commit efa7c39 into master Mar 13, 2019
@kubermatic-bot kubermatic-bot deleted the 229-dynamic-audit-log branch March 13, 2019 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdomanski kdomanski kdomanski left review comments

@xmudrii xmudrii Awaiting requested review from xmudrii

Assignees

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kron4eg @xmudrii @kubermatic-bot @kdomanski