Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/v1.7] fix: Deploy User defined addons before external CCM initialization #3068

Merged
merged 1 commit into from
Mar 5, 2024
Merged

[release/v1.7] fix: Deploy User defined addons before external CCM initialization #3068

merged 1 commit into from
Mar 5, 2024

Conversation

kubermatic-bot
Copy link
Contributor

This is an automated cherry-pick of #3065

/assign kron4eg

fix: Deploy User defined addons before external CCM initialization

@kubermatic-bot kubermatic-bot mentioned this pull request Mar 5, 2024
Merged
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 5, 2024
@kron4eg
Copy link
Member

kron4eg commented Mar 5, 2024

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 5, 2024
@kubermatic-bot
Copy link
Contributor Author

LGTM label has been added.

Git tree hash: 7df44a98047c918ff421ecef0f9a6d856109c320

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2024
@kron4eg
Copy link
Member

kron4eg commented Mar 5, 2024

cc @kubermatic/sig-release-managers

ahmedwaleedmalik
ahmedwaleedmalik approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

xmudrii
xmudrii approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubermatic-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, kron4eg, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ahmedwaleedmalik,kron4eg,xmudrii]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xmudrii
Copy link
Member

xmudrii commented Mar 5, 2024

/kind bug

@kubermatic-bot kubermatic-bot added kind/bug Categorizes issue or PR as related to a bug. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Mar 5, 2024
@xmudrii xmudrii added the cherry-pick-approved Indicates a PR has been approved by release managers. label Mar 5, 2024
@kubermatic-bot kubermatic-bot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Mar 5, 2024
@kubermatic-bot kubermatic-bot merged commit fcee227 into kubermatic:release/v1.7 Mar 5, 2024
13 checks passed
@kubermatic-bot kubermatic-bot deleted the cherry-pick-3065-to-release/v1.7 branch March 5, 2024 14:25
@sschmittsva sschmittsva mentioned this pull request Jun 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

Assignees

@kron4eg kron4eg

@ahmedwaleedmalik ahmedwaleedmalik

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a PR has been approved by release managers. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kubermatic-bot @kron4eg @xmudrii @ahmedwaleedmalik