Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preliminary GCE example Terraform config #307

Merged
merged 3 commits into from
Mar 26, 2019
Merged

Preliminary GCE example Terraform config #307

merged 3 commits into from
Mar 26, 2019

Conversation

xrstf
Copy link
Contributor

@xrstf xrstf commented Mar 25, 2019 •
edited by kron4eg
Loading

What this PR does / why we need it:
This PR adds a terraform configuration for spinning up machines on GCE.

Fixes #305

Release note:

add GCE Terraform examples

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: no Denotes that at least one commit in the pull request doesn't have a valid DCO signoff message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 25, 2019
@xrstf
Copy link
Contributor Author

xrstf commented Mar 25, 2019

/retest

@xrstf xrstf added dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. and removed dco-signoff: no Denotes that at least one commit in the pull request doesn't have a valid DCO signoff message. labels Mar 25, 2019
xmudrii
xmudrii reviewed Mar 25, 2019
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some questions.

TODO (can be a follow up):

  • output.tf
  • SSH variables in the variables.tf file

examples/terraform/gce/main.tf Outdated Show resolved Hide resolved
examples/terraform/gce/main.tf
ports = ["${var.ssh_port}"]
}

source_ranges = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't sure is this required or not.

examples/terraform/gce/main.tf
protocol = "icmp"
}

source_ranges = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this all we need to do to have internal only firewall rule?

examples/terraform/gce/main.tf
}

service_account {
scopes = ["compute-rw", "storage-ro"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What we should put here? Are those ServiceAccount Scopes okay?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that our GKE nodes have this

Compute Engine: Read Write
Service Control: Enabled
Service Management: Read Write
Stackdriver Logging API: Write Only
Stackdriver Monitoring API: Write Only
Storage: Read Only

examples/terraform/gce/variables.tf Show resolved Hide resolved
examples/terraform/gce/variables.tf Show resolved Hide resolved
@xrstf
Copy link
Contributor Author

xrstf commented Mar 25, 2019

/retest

3 similar comments
@xrstf
Copy link
Contributor Author

xrstf commented Mar 25, 2019

/retest

@kron4eg
Copy link
Member

kron4eg commented Mar 26, 2019

/retest

@xmudrii
Copy link
Member

xmudrii commented Mar 26, 2019

/retest

@xmudrii
Copy link
Member

xmudrii commented Mar 26, 2019

/retest
/test pull-kubeone-verify-boilerplate

@xmudrii
Copy link
Member

xmudrii commented Mar 26, 2019

/retest

2 similar comments
@xrstf
Copy link
Contributor Author

xrstf commented Mar 26, 2019

/retest

@xmudrii
Copy link
Member

xmudrii commented Mar 26, 2019

/retest

xmudrii and others added 3 commits March 26, 2019 22:04
@xmudrii @kron4eg
GCP terraform
006ee74 
Signed-off-by: Marko Mudrinić <[email protected]>
@xrstf @kron4eg
fix health check and add SSH support
e515569 
Signed-off-by: Christoph Mewes <[email protected]>
@kron4eg
format gce tf config
035702f 
Signed-off-by: Artiom Diomin <[email protected]>
@kron4eg
Copy link
Member

kron4eg commented Mar 26, 2019

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 48492a31e82ddd407bd5301e86daa638f386c0ec

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2019
@kubermatic-bot kubermatic-bot merged commit 0d78cdf into master Mar 26, 2019
@kubermatic-bot kubermatic-bot deleted the terraform/gce branch March 26, 2019 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii left review comments

@kron4eg kron4eg kron4eg left review comments

Assignees

@kron4eg kron4eg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xrstf @kron4eg @xmudrii @kubermatic-bot