Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait 10 seconds before upgrading next node #316

Merged
merged 1 commit into from
Mar 27, 2019
Merged

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Mar 27, 2019

What this PR does / why we need it:

This PR adds a delay of ten seconds before proceeding to the next node to ensure that all components have enough time to restart. This potentially fixes issues and flakes for upgrades on DigitalOcean.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
xref #269

Release note:

Add ten seconds delay before upgrading the next node.

/assign @kron4eg

@xmudrii xmudrii requested a review from kron4eg March 27, 2019 15:28
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 27, 2019
Copy link
Member

@kron4eg kron4eg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2285d16dd82fb7ece5218f3457a98b67875d9025

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 27, 2019
@xmudrii
Copy link
Member Author

xmudrii commented Mar 27, 2019

/test pull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.0
This failed on leader 🤔

@kubermatic-bot kubermatic-bot merged commit fcdc823 into master Mar 27, 2019
@kubermatic-bot kubermatic-bot deleted the upgrade-sleep branch March 27, 2019 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants