Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the Terraform workerset integration for Hetzner #331

Merged
merged 2 commits into from
Apr 3, 2019
Merged

Add the Terraform workerset integration for Hetzner #331

merged 2 commits into from
Apr 3, 2019

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Apr 3, 2019

What this PR does / why we need it:

This PR adds the Terraform workerset integration for Hetzner. The following information about worker nodes can be sourced from Terraform:

  • Server type
  • Datacenter
  • Location

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Required for #165

Release note:

Add the Terraform workerset integration for Hetzner

/assign @kron4eg

@xmudrii xmudrii requested a review from kron4eg April 3, 2019 13:18
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 3, 2019
kron4eg
kron4eg approved these changes Apr 3, 2019
View reviewed changes
Copy link
Member

@kron4eg kron4eg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 3, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f19dc51cd0d1d6697fece3b47338ac550b6e7b20

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 3, 2019
@kubermatic-bot kubermatic-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 3, 2019
@kron4eg
Copy link
Member

kron4eg commented Apr 3, 2019

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 3, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1630af96e71358d5cd0b7c30d21d915dc672bac4

@kubermatic-bot kubermatic-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 3, 2019
@kubermatic-bot kubermatic-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 3, 2019
@kron4eg
Copy link
Member

kron4eg commented Apr 3, 2019

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 3, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7e2b04d8fc667eb5a2c6f0edb642c184e558b2e4

@xmudrii
Copy link
Member Author

xmudrii commented Apr 3, 2019

/retest

@kubermatic-bot kubermatic-bot merged commit 9479556 into master Apr 3, 2019
@kubermatic-bot kubermatic-bot deleted the tf-hetzner branch April 3, 2019 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kron4eg kron4eg kron4eg approved these changes

Assignees

@kron4eg kron4eg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xmudrii @kubermatic-bot @kron4eg