Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set HttpPutResponseHopLimit to 3 by default for AWS nodes #3328

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Aug 1, 2024

What this PR does / why we need it:

Set HttpPutResponseHopLimit on AWS control plane and static worker nodes to 3 in order to support the IMSD v2 API. This can be further adjusted using control_plane_http_put_max_hops and static_workers_http_put_max_hops Terraform variables. However, max 3 hops are the minimum recommended in the containerized environments (see cilium/cilium#25232).

What type of PR is this?

/kind feature

Does this PR introduce a user-facing change? Then add your Release Note here:

Set `HttpPutResponseHopLimit` on AWS control plane and static worker nodes to 3 in order to support the IMSD v2 API

Documentation:

NONE

/assign @kron4eg

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. docs/none Denotes a PR that doesn't need documentation (changes). labels Aug 1, 2024
@kubermatic-bot kubermatic-bot added dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 1, 2024
@xmudrii
Copy link
Member Author

xmudrii commented Aug 1, 2024

/cherrypick release/v1.8

@kubermatic-bot
Copy link
Contributor

@xmudrii: once the present PR merges, I will cherry-pick it on top of release/v1.8 in a new PR and assign it to you.

In response to this:

/cherrypick release/v1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@xmudrii
Copy link
Member Author

xmudrii commented Aug 1, 2024

/cherrypick release/v1.7

@kubermatic-bot
Copy link
Contributor

@xmudrii: once the present PR merges, I will cherry-pick it on top of release/v1.7 in a new PR and assign it to you.

In response to this:

/cherrypick release/v1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@xmudrii
Copy link
Member Author

xmudrii commented Aug 1, 2024

/test pull-kubeone-e2e-aws-default-cilium-containerd-external-v1.30.1

@xmudrii
Copy link
Member Author

xmudrii commented Aug 1, 2024

/test pull-kubeone-e2e-aws-default-cilium-containerd-external-v1.30.1

1 similar comment
@xmudrii
Copy link
Member Author

xmudrii commented Aug 1, 2024

/test pull-kubeone-e2e-aws-default-cilium-containerd-external-v1.30.1

@xmudrii
Copy link
Member Author

xmudrii commented Aug 1, 2024

/override pull-kubeone-e2e-aws-default-cilium-containerd-external-v1.30.1
Known issue, Cilium conformance tests are not passing.
@kron4eg Ready for review

@kubermatic-bot
Copy link
Contributor

@xmudrii: Overrode contexts on behalf of xmudrii: pull-kubeone-e2e-aws-default-cilium-containerd-external-v1.30.1

In response to this:

/override pull-kubeone-e2e-aws-default-cilium-containerd-external-v1.30.1
Known issue, Cilium conformance tests are not passing.
@kron4eg Ready for review

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@kron4eg kron4eg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 2, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 86985c71120dd111a90dd13ed26b7ede3028eea8

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2024
@kubermatic-bot kubermatic-bot merged commit 93a74ee into main Aug 2, 2024
14 checks passed
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.9 milestone Aug 2, 2024
@kubermatic-bot kubermatic-bot deleted the aws-put-hops branch August 2, 2024 05:07
@kubermatic-bot
Copy link
Contributor

@xmudrii: new pull request created: #3329

In response to this:

/cherrypick release/v1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubermatic-bot
Copy link
Contributor

@xmudrii: new pull request created: #3330

In response to this:

/cherrypick release/v1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants