-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set HttpPutResponseHopLimit to 3 by default for AWS nodes #3328
Conversation
/cherrypick release/v1.8 |
@xmudrii: once the present PR merges, I will cherry-pick it on top of release/v1.8 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cherrypick release/v1.7 |
@xmudrii: once the present PR merges, I will cherry-pick it on top of release/v1.7 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test pull-kubeone-e2e-aws-default-cilium-containerd-external-v1.30.1 |
Signed-off-by: Marko Mudrinić <[email protected]>
/test pull-kubeone-e2e-aws-default-cilium-containerd-external-v1.30.1 |
1 similar comment
/test pull-kubeone-e2e-aws-default-cilium-containerd-external-v1.30.1 |
/override pull-kubeone-e2e-aws-default-cilium-containerd-external-v1.30.1 |
@xmudrii: Overrode contexts on behalf of xmudrii: pull-kubeone-e2e-aws-default-cilium-containerd-external-v1.30.1 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
LGTM label has been added. Git tree hash: 86985c71120dd111a90dd13ed26b7ede3028eea8
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kron4eg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@xmudrii: new pull request created: #3329 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@xmudrii: new pull request created: #3330 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
Set
HttpPutResponseHopLimit
on AWS control plane and static worker nodes to 3 in order to support the IMSD v2 API. This can be further adjusted usingcontrol_plane_http_put_max_hops
andstatic_workers_http_put_max_hops
Terraform variables. However, max 3 hops are the minimum recommended in the containerized environments (see cilium/cilium#25232).What type of PR is this?
/kind feature
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation:
/assign @kron4eg