Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vSphere images to use upstream image repository or our mirror #3376

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Sep 17, 2024

What this PR does / why we need it:

This PR replaces the registry used for vSphere CCM and CSI images. Unfortunately:

  • The new vSphere CCM image registry has images only starting from v1.28.0
  • There are no images in the new official vSphere CSI image registry at the moment

Because of that, we unfortunately have to resort to the mirroring the old/unavailable images.

Which issue(s) this PR fixes:
xref #3375

What type of PR is this?
/kind bug
/kind regression
/priority critical-urgent

Does this PR introduce a user-facing change? Then add your Release Note here:

[ACTION REQUIRED] Fix vSphere CCM and CSI images. The CCM images for versions starting with v1.28.0 are pulled from the new community-owned image repository. The CCM images for versions prior to v1.28.0, and the CSI images, are pulled from the Kubermatic-managed mirror on `quay.io`. If you have a vSphere cluster, we strongly recommend upgrading to the latest KubeOne patch release and running `kubeone apply` **as soon as possible**, because the old image repository (`gcr.io/cloud-provider-vsphere`) is not available anymore, hence it's not possible to pull the needed images from that repository

Documentation:

TBD

@kubermatic-bot kubermatic-bot added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. docs/tbd Denotes a PR that needs documentation (change) that will be done later. kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/regression Categorizes issue or PR as related to a regression from a prior release. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 17, 2024
@xmudrii
Copy link
Member Author

xmudrii commented Sep 17, 2024

/test pull-kubeone-e2e-vsphere-default-install-containerd-external-v1.28.13

@xmudrii
Copy link
Member Author

xmudrii commented Sep 17, 2024

/cherrypick release/v1.8

@kubermatic-bot
Copy link
Contributor

@xmudrii: once the present PR merges, I will cherry-pick it on top of release/v1.8 in a new PR and assign it to you.

In response to this:

/cherrypick release/v1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@xmudrii xmudrii changed the title Update vSphere images to use our mirror Update vSphere images to use upstream image repository or our mirror Sep 17, 2024
@kron4eg
Copy link
Member

kron4eg commented Sep 17, 2024

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: add88950e7e4d31885d3cc219a904c6d2e383218

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2024
@xmudrii
Copy link
Member Author

xmudrii commented Sep 17, 2024

/retest

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@xmudrii
Copy link
Member Author

xmudrii commented Sep 17, 2024

/override pull-kubeone-e2e-vsphere-default-install-containerd-external-v1.28.13
Testing manually

@kubermatic-bot
Copy link
Contributor

@xmudrii: Overrode contexts on behalf of xmudrii: pull-kubeone-e2e-vsphere-default-install-containerd-external-v1.28.13

In response to this:

/override pull-kubeone-e2e-vsphere-default-install-containerd-external-v1.28.13
Testing manually

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubermatic-bot kubermatic-bot merged commit 9bb5959 into main Sep 17, 2024
14 of 15 checks passed
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.9 milestone Sep 17, 2024
@kubermatic-bot kubermatic-bot deleted the vsphere-mirror branch September 17, 2024 17:11
@kubermatic-bot
Copy link
Contributor

@xmudrii: new pull request could not be created: failed to create pull request against kubermatic/kubeone#release/v1.8 from head kubermatic-bot:cherry-pick-3376-to-release/v1.8: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between kubermatic:release/v1.8 and kubermatic-bot:cherry-pick-3376-to-release/v1.8"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"}

In response to this:

/cherrypick release/v1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/tbd Denotes a PR that needs documentation (change) that will be done later. kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm Indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants