Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional machinecontroller fields in terraform config #454

Merged
merged 3 commits into from
May 27, 2019
Merged

Additional machinecontroller fields in terraform config #454

merged 3 commits into from
May 27, 2019

Conversation

kron4eg
Copy link
Member

@kron4eg kron4eg commented May 17, 2019

Fixes #416

machinecontroller upgraded to 1.1.8

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 17, 2019
@kron4eg
Copy link
Member Author

kron4eg commented May 19, 2019

/retest

@kron4eg kron4eg changed the title WIP: Additional machinecontroller fields in terraform config Additional machinecontroller fields in terraform config May 19, 2019
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 19, 2019
@kron4eg kron4eg changed the title Additional machinecontroller fields in terraform config WIP: Additional machinecontroller fields in terraform config May 19, 2019
@kubermatic-bot kubermatic-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 19, 2019
@kron4eg
Copy link
Member Author

kron4eg commented May 19, 2019

waiting for #453 to be merged to update TF configs and avoid huge conflict

@xmudrii
Copy link
Member

xmudrii commented May 20, 2019

The #453 is now merged. :shipit:

@kron4eg kron4eg changed the title WIP: Additional machinecontroller fields in terraform config Additional machinecontroller fields in terraform config May 20, 2019
@kubermatic-bot kubermatic-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 20, 2019
@kron4eg kron4eg changed the title Additional machinecontroller fields in terraform config WIP: Additional machinecontroller fields in terraform config May 20, 2019
@kubermatic-bot kubermatic-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 20, 2019
@kron4eg
Copy link
Member Author

kron4eg commented May 27, 2019

/test pull-kubeone-test

@kron4eg
Copy link
Member Author

kron4eg commented May 27, 2019

/test pull-kubeone-e2e-aws-upgrade-1.13.5-1.14.1

@kron4eg kron4eg changed the title WIP: Additional machinecontroller fields in terraform config Additional machinecontroller fields in terraform config May 27, 2019
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 27, 2019
@xmudrii
Copy link
Member

xmudrii commented May 27, 2019

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 89becd655f41b0f861600b90f2b61d7129a67220

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2019
@kubermatic-bot kubermatic-bot merged commit 19e5e6b into master May 27, 2019
@kubermatic-bot kubermatic-bot deleted the 416-mc-gce branch May 27, 2019 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii left review comments

Assignees

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update machine-controller to v1.1.8
3 participants
@kron4eg @xmudrii @kubermatic-bot