Azure support #469
Azure support #469
Conversation
kubermatic-bot
added
release-note
Signed-off-by: Artiom Diomin <[email protected]>
kubermatic-bot
added
size/L
Signed-off-by: Artiom Diomin <[email protected]>
* machinecontroller contains fix for azure credentials * use short hostname on azure Signed-off-by: Artiom Diomin <[email protected]>
Signed-off-by: Artiom Diomin <[email protected]>
kubermatic-bot
added
size/XL
Signed-off-by: Artiom Diomin <[email protected]>
Signed-off-by: Artiom Diomin <[email protected]>
kubermatic-bot
removed
the
do-not-merge/work-in-progress
|
/retest |
There was a problem hiding this comment.
I left a question, but beside that I'd also like to see:
- Quickstart for Azure
- Environment variables documented in the
environment_variables.mddocument - Documentation updated to mention that we support Azure
- This could be a follow-up once we do the release, but we should ensure we don't forget it
I'm not going to block on this, so if you want, you can do it in a follow-up.
Otherwise LGTM 💯
| # Provider specific settings | ||
|
|
||
| variable "location" { | ||
| description = "" |
There was a problem hiding this comment.
Are those descriptions missing intentionally? Should we add descriptions?
There was a problem hiding this comment.
Apparently just missed it 🤷♂️
Signed-off-by: Artiom Diomin <[email protected]>
|
@xmudrii I've addressed (I think all) those comments, PTAL again. |
Signed-off-by: Artiom Diomin <[email protected]>
| @@ -60,6 +60,7 @@ func ValidateCloudProviderSpec(p kubeone.CloudProviderSpec, fldPath *field.Path) | |||
|
|
|||
| switch p.Name { | |||
| case kubeone.CloudProviderNameAWS: | |||
| case kubeone.CloudProviderNameAzure: | |||
There was a problem hiding this comment.
Is cloudConfig required for Azure? If yes, should we enforce it here?
There was a problem hiding this comment.
yeah... actually it's required for vSphere too and I don't remember that I've done it 😅
* azure * vsphere Signed-off-by: Artiom Diomin <[email protected]>
|
LGTM label has been added. Git tree hash: 9495f7b0f48705d102385f1f56ef00aaaa723f7e
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
the
approved
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
@kron4eg: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/override pull-kubeone-e2e-digitalocean-conformance-1.13.5 DO API strikes again: 503 Service is currently unavailable. |
|
@kron4eg: Overrode contexts on behalf of kron4eg: pull-kubeone-e2e-digitalocean-conformance-1.13.5 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| versions: | ||
| kubernetes: '1.14.2' | ||
| cloudProvider: | ||
| name: 'vsphere' |
| ``` | ||
|
|
||
| This command will wait for all worker nodes to be gone. Once it's done you can | ||
| proceed and destroy the vSphere infrastructure using Terraform: |
There was a problem hiding this comment.
Another copy/paste error. Replace 'vSphere' with 'Azure'
Fixes #455