Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade machinecontroller to v1.2.0 #490

Merged
merged 3 commits into from
Jun 12, 2019
Merged

Upgrade machinecontroller to v1.2.0 #490

merged 3 commits into from
Jun 12, 2019

Conversation

kron4eg
Copy link
Member

@kron4eg kron4eg commented Jun 12, 2019

What this PR does / why we need it:
This PR brings proxy support for worker nodes

original PR: kubermatic/machine-controller#559

* Proxy support for worker nodes

@kron4eg
Upgrade machinecontroller to v1.2.0
b401a91 
* add support for proxies in worker nodes

Signed-off-by: Artiom Diomin <[email protected]>
@kron4eg kron4eg requested a review from xmudrii June 12, 2019 09:57
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 12, 2019
xmudrii
xmudrii requested changes Jun 12, 2019
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Cluster-API version has been changed. Please update the dependency.
  • It would be nice to update the comment here to mention that this configures workers as well.

@kubermatic-bot kubermatic-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 12, 2019
@kron4eg
Copy link
Member Author

kron4eg commented Jun 12, 2019

@xmudrii fixed.

@xmudrii
Copy link
Member

xmudrii commented Jun 12, 2019

/retest

xmudrii
xmudrii approved these changes Jun 12, 2019
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 12, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fb42bfc12fb57f18befed9ca7592004b70500c22

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 12, 2019
@kron4eg
Copy link
Member Author

kron4eg commented Jun 12, 2019

/retest

@kubermatic-bot kubermatic-bot merged commit 8295796 into master Jun 12, 2019
@kubermatic-bot kubermatic-bot deleted the mc-1.2.0 branch June 12, 2019 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

Assignees

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kron4eg @xmudrii @kubermatic-bot