Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BREAKING]: terraform outputs directly unmarshaled to kubeone API strucures #503

Merged
merged 1 commit into from
Jun 19, 2019
Merged

[BREAKING]: terraform outputs directly unmarshaled to kubeone API strucures #503

merged 1 commit into from
Jun 19, 2019

Conversation

kron4eg
Copy link
Member

@kron4eg kron4eg commented Jun 18, 2019 •
edited
Loading

What this PR does / why we need it:
To avoid collision with GCE network

[BREAKING] terraform output to match config.yaml format

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 18, 2019
@kron4eg kron4eg changed the title Source static network config from terraform WIP: Source static network config from terraform Jun 19, 2019
@kubermatic-bot kubermatic-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 19, 2019
@kubermatic-bot kubermatic-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 19, 2019
@kron4eg kron4eg changed the title WIP: Source static network config from terraform [BEAKING]: terraform outputs directly unmarshaled to kubeone API strucures Jun 19, 2019
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 19, 2019
@kron4eg kron4eg changed the title [BEAKING]: terraform outputs directly unmarshaled to kubeone API strucures [BREAKING]: terraform outputs directly unmarshaled to kubeone API strucures Jun 19, 2019
xmudrii
xmudrii approved these changes Jun 19, 2019
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/test pull-kubeone-e2e-digitalocean-conformance-1.14.3
/hold
for @eqrx to review and DigitalOcean test to pass

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 19, 2019
@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 19, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 958a3439452732fb7a88dbe14dd6df3215dfbf72

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 19, 2019
eqrx
eqrx approved these changes Jun 19, 2019
View reviewed changes
Copy link
Contributor

@eqrx eqrx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice change :)

@kron4eg
Copy link
Member Author

kron4eg commented Jun 19, 2019

/hold cancel

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 19, 2019
@kubermatic-bot kubermatic-bot merged commit 986b4bc into master Jun 19, 2019
@kubermatic-bot kubermatic-bot deleted the static_network_spec branch June 19, 2019 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

@eqrx eqrx eqrx approved these changes

Assignees

@xmudrii xmudrii

@eqrx eqrx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kron4eg @kubermatic-bot @xmudrii @eqrx