Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make reset a bit more robust #508

Merged
merged 1 commit into from
Jun 23, 2019
Merged

Make reset a bit more robust #508

merged 1 commit into from
Jun 23, 2019

Conversation

kron4eg
Copy link
Member

@kron4eg kron4eg commented Jun 23, 2019

  • Retry failed operations
  • Don't error out on not found some of the objects that can be deleted by controllers (avoid race-condition)
  • Log a message to try to use --destroy-workers=false flag

Fixes #474

kubeone reset more robust

@kron4eg kron4eg requested a review from xmudrii June 23, 2019 10:24
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 23, 2019
xmudrii
xmudrii reviewed Jun 23, 2019
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a tiny nit. It'd be nice to extend the message, so the user knows what happened if we don't have that already in place.

pkg/installer/installation/reset.go Outdated Show resolved Hide resolved
xmudrii added a commit that referenced this pull request Jun 23, 2019
@xmudrii
Add #508 to the changelog
4b12fde 
Signed-off-by: Marko Mudrinić <[email protected]>
@kron4eg
Make reset a bit more robust
d233db0 
* Retry failed operations
* Don't error out on not found some of the objects that can be deleted by controllers (avoid race-condition)
* Log a message to try to use --destroy-workers=false flag

Signed-off-by: Artiom Diomin <[email protected]>
xmudrii
xmudrii approved these changes Jun 23, 2019
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b203e434f60458481425e7f0fb41070a2f502534

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2019
@kron4eg
Copy link
Member Author

kron4eg commented Jun 23, 2019

/retest

@kubermatic-bot kubermatic-bot merged commit 6aa53f7 into master Jun 23, 2019
@kubermatic-bot kubermatic-bot deleted the 474-reset-retry branch June 23, 2019 19:10
xmudrii added a commit that referenced this pull request Jul 1, 2019
@xmudrii
Add #508 to the changelog
d303140 
Signed-off-by: Marko Mudrinić <[email protected]>
xmudrii added a commit that referenced this pull request Jul 2, 2019
@xmudrii
Add #508 to the changelog
de3862a 
Signed-off-by: Marko Mudrinić <[email protected]>
kubermatic-bot pushed a commit that referenced this pull request Jul 2, 2019
@xmudrii @kubermatic-bot
Prepare for the release v0.9.0 (#504)
dd2e1ea 
* Update README.md

* Make install steps version-agnostic
* Recommend using officially released versions over running
of the master branch
* Mention that support for package managers is work in progress
* Add support for Kubernetes 1.15 to the compatibility table
* Minor updates and preparation for v0.9

Signed-off-by: Marko Mudrinić <[email protected]>

* Update the release process document

Signed-off-by: Marko Mudrinić <[email protected]>

* Add changelog for release v0.9.0

Signed-off-by: Marko Mudrinić <[email protected]>

* Add #508 to the changelog

Signed-off-by: Marko Mudrinić <[email protected]>

* Add #486 to the changelog

Signed-off-by: Marko Mudrinić <[email protected]>

* Update CHANGELOG.md with recent changes

Signed-off-by: Marko Mudrinić <[email protected]>

* Minor README improvements

Signed-off-by: Marko Mudrinić <[email protected]>

* Revert NodeLocalDNSCache

Signed-off-by: Marko Mudrinić <[email protected]>

* Change v0.9 release date in changelog

Signed-off-by: Marko Mudrinić <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

Assignees

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kubeone reset fails when LB is not functioning
3 participants
@kron4eg @kubermatic-bot @xmudrii