Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade digitalocean CCM to v0.1.15 #516

Merged
merged 1 commit into from
Jun 27, 2019
Merged

Upgrade digitalocean CCM to v0.1.15 #516

merged 1 commit into from
Jun 27, 2019

Conversation

kron4eg
Copy link
Member

@kron4eg kron4eg commented Jun 27, 2019 

Upgrade digitalocean CCM to v0.1.15

@kron4eg kron4eg requested a review from xmudrii June 27, 2019 21:23
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 27, 2019
xmudrii
xmudrii reviewed Jun 27, 2019
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a difference in a command used to run the CCM between v0.1.9 and v0.1.15.

Can you check do we need to update it?

32c32
<       - image: digitalocean/digitalocean-cloud-controller-manager:v0.1.9
---
>       - image: digitalocean/digitalocean-cloud-controller-manager:v0.1.15
36d35
<           - "--cloud-provider=digitalocean"

@kron4eg
Copy link
Member Author

kron4eg commented Jun 27, 2019

@xmudrii technically we could continue to use that --cloud-controller=digitalocean flag, and nothing would be changed (because according to release notes it's like that by default), but yeah, it's better to remove it to not forget about it later. So, it's removed now.

xmudrii
xmudrii approved these changes Jun 27, 2019
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 27, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1f36e31693ad91ee3807bf6ba90366377640b9c0

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2019
@xmudrii
Copy link
Member

xmudrii commented Jun 27, 2019

/test pull-kubeone-e2e-digitalocean-conformance-1.15
/hold
Unhold once DO test is green

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 27, 2019
@kron4eg
Copy link
Member Author

kron4eg commented Jun 27, 2019

/hold cancel

pull-kubeone-e2e-digitalocean-conformance-1.15 — Job succeeded.

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 27, 2019
@xmudrii
Copy link
Member

xmudrii commented Jun 27, 2019

/retest

1 similar comment
@xmudrii
Copy link
Member

xmudrii commented Jun 27, 2019

/retest

@kubermatic-bot kubermatic-bot merged commit 3142db7 into master Jun 27, 2019
@kubermatic-bot kubermatic-bot deleted the upgrade-do-ccm branch June 27, 2019 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

Assignees

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kron4eg @kubermatic-bot @xmudrii