Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bastion support #567

Merged
merged 4 commits into from
Jul 9, 2019
Merged

Bastion support #567

merged 4 commits into from
Jul 9, 2019

Conversation

kron4eg
Copy link
Member

@kron4eg kron4eg commented Jul 6, 2019

What this PR does / why we need it:
Provides bastion support

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #337

Special notes for your reviewer:
Terraform config in aws-private requires pre-existing VPC provided via vars or alternatively var.subnet_offset/var.subnet_netmask_bits should be adjusted in order to avoid collision with existing subnets.

Support for SSH over bastion host

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 6, 2019
* Always use hostnames provided by AWS
* Generate hostnames for Azure

Signed-off-by: Artiom Diomin <[email protected]>
@kron4eg kron4eg changed the title WIP Bastion support Bastion support Jul 8, 2019
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 8, 2019
@kron4eg
Copy link
Member Author

kron4eg commented Jul 8, 2019

/test pull-kubeone-test

Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2019
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 94d44a77186ccf3c23aa34d2ffee9dbc04fd2d2f

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 9, 2019
@kubermatic-bot kubermatic-bot merged commit 782498e into master Jul 9, 2019
@kubermatic-bot kubermatic-bot deleted the bastion_support branch July 9, 2019 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support bastion/jump SSH host
3 participants