-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update machine-controller to v1.4.2 and add additional OpenStack field #572
Conversation
@@ -67,6 +67,8 @@ output "kubeone_workers" { | |||
# Otherwise, the rootDisk will be on ephemeral storage and its size will | |||
# be derived from the flavor | |||
rootDiskSizeGB = 50 | |||
# Optional: limit how much volumes can be attached to a node |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't found a comment for this field in machine-controller examples, but I assumed it from the field name. Is this comment correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: 83b64f42e00db6ac77f1229176ef21e29c9abd01
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kron4eg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold needs to be tested manually on azure |
Signed-off-by: Marko Mudrinić <[email protected]>
Signed-off-by: Marko Mudrinić <[email protected]>
/hold cancel |
LGTM label has been added. Git tree hash: 8f5cd109a3ada8aa932f2684a90bd9338bb92d1a
|
What this PR does / why we need it:
This PR updates machine-controller to v1.4.2 and adds an optional OpenStack field
nodeVolumeAttachLimit
.Does this PR introduce a user-facing change?:
/assign @kron4eg