Take static networking into account when contructing machineDeployment #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubermatic-bot
added
release-note
kron4eg
commented
Jul 29, 2019
| @@ -75,15 +67,14 @@ func createMachineDeployment(cluster *kubeoneapi.KubeOneCluster, workerset kubeo | |||
| return nil, errors.Wrap(err, "failed to generate machineSpec") | |||
| } | |||
|
|
|||
| config := providerSpec{ | |||
There was a problem hiding this comment.
we don't need special providerSpec struct, we already have everything in put API, we this change introduce using existing structs.
kron4eg
commented
Jul 29, 2019
| @@ -96,6 +87,12 @@ func createMachineDeployment(cluster *kubeoneapi.KubeOneCluster, workerset kubeo | |||
| "workerset": workerset.Name, | |||
| } | |||
|
|
|||
| if workerset.Config.Network != nil { | |||
| // we have static network config | |||
There was a problem hiding this comment.
static network config is kinda special case and we need to flip those maxSurge and maxUnavailable
Signed-off-by: Artiom Diomin <[email protected]>
kubermatic-bot
added
size/M
|
/retest |
|
LGTM label has been added. Git tree hash: 66811f22341864fc8b6236f4817492ebb921a6e7
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We had Network config structures already, but never used them, so this PR fixes this unfortunate incident.