Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GCE docs to configure clusters as regional #732

Merged
merged 1 commit into from
Nov 5, 2019
Merged

Update GCE docs to configure clusters as regional #732

merged 1 commit into from
Nov 5, 2019

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Nov 5, 2019

What this PR does / why we need it:

This PR updates docs for GCE to configure clusters as regional by providing cloudConfig. More information about regional clusters can be found here: https://cloud.google.com/kubernetes-engine/docs/concepts/regional-clusters

Does this PR introduce a user-facing change?:

NONE

/assign @kron4eg

@xmudrii xmudrii requested a review from kron4eg November 5, 2019 11:59
@kubermatic-bot kubermatic-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Nov 5, 2019
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 5, 2019
kron4eg
kron4eg approved these changes Nov 5, 2019
View reviewed changes
Copy link
Member

@kron4eg kron4eg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 5, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 59060b9b6388e6065f449649a76eb24419c33b6b

@kubermatic-bot kubermatic-bot merged commit e06d099 into master Nov 5, 2019
@kubermatic-bot kubermatic-bot added this to the v0.11 milestone Nov 5, 2019
@kubermatic-bot kubermatic-bot deleted the gce-regional branch November 5, 2019 12:56
@toschneck toschneck mentioned this pull request Feb 2, 2020
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kron4eg kron4eg kron4eg approved these changes

Assignees

@kron4eg kron4eg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v0.11
Development

Successfully merging this pull request may close these issues.
3 participants
@xmudrii @kubermatic-bot @kron4eg