Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pod2daemon-flexvol and volume definition from canal manifest #756

Merged
merged 1 commit into from
Dec 10, 2019

Conversation

kron4eg
Copy link
Member

@kron4eg kron4eg commented Dec 10, 2019

What this PR does / why we need it:
This volume causes problems on CoreOS

Special notes for your reviewer:
projectcalico/calico#2712

Does this PR introduce a user-facing change?:

removed flexvolume support from canal

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Dec 10, 2019
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 10, 2019
@xrstf
Copy link
Contributor

xrstf commented Dec 10, 2019

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b13d2413b50f0dbc0971e1150d2715fb892757c5

@kron4eg
Copy link
Member Author

kron4eg commented Dec 10, 2019

/retest

@kubermatic-bot kubermatic-bot merged commit dd106a0 into master Dec 10, 2019
@kubermatic-bot kubermatic-bot added this to the v0.11 milestone Dec 10, 2019
@kubermatic-bot kubermatic-bot deleted the canal-flexvol branch December 10, 2019 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants