Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Addons #782

Merged
merged 12 commits into from
Feb 11, 2020
Merged

Implement Addons #782

merged 12 commits into from
Feb 11, 2020

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Feb 6, 2020

What this PR does / why we need it:

This PR implements the KubeOne Addons, as described in the Addons proposal.

Special notes for your reviewer:

The documentation will be done in a follow-up PR.

Does this PR introduce a user-facing change?:

Implement Addons

/assign @kron4eg
/hold

@xmudrii xmudrii requested a review from kron4eg February 6, 2020 15:41
@kubermatic-bot kubermatic-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 6, 2020
kron4eg
kron4eg reviewed Feb 6, 2020
View reviewed changes
pkg/addons/manifest.go Show resolved Hide resolved
pkg/addons/manifest.go Outdated Show resolved Hide resolved
pkg/addons/manifest.go Outdated Show resolved Hide resolved
pkg/addons/manifest.go Outdated Show resolved Hide resolved
pkg/addons/addons.go Outdated Show resolved Hide resolved
pkg/addons/manifest.go Show resolved Hide resolved
@xmudrii
Copy link
Member Author

xmudrii commented Feb 10, 2020

/retest

@kubermatic-bot kubermatic-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 11, 2020
@xmudrii
Copy link
Member Author

xmudrii commented Feb 11, 2020

/hold cancel

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 11, 2020
@kron4eg
Copy link
Member

kron4eg commented Feb 11, 2020

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 11, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7cc0813812be93a2176221ef0e81390aaca319bf

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot merged commit df79794 into master Feb 11, 2020
@kubermatic-bot kubermatic-bot added this to the v0.11 milestone Feb 11, 2020
@kubermatic-bot kubermatic-bot deleted the addons branch February 11, 2020 17:59
@xmudrii xmudrii mentioned this pull request Feb 12, 2020
Merged
@kron4eg kron4eg mentioned this pull request Apr 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kron4eg kron4eg kron4eg left review comments

Assignees

@kron4eg kron4eg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v0.11
Development

Successfully merging this pull request may close these issues.
3 participants
@xmudrii @kron4eg @kubermatic-bot