Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for 3.7 (workaround) #67

Merged
merged 1 commit into from
Jul 11, 2018

Conversation

tomplus
Copy link
Member

@tomplus tomplus commented Jul 8, 2018

Python 3.7 treats async as a reserved keywords. Unfortunately this phrase is used by swagger-codegen to call function in the asynchronous way (in a thread pool). I've created a fix for swagger-codegen (use async_req instead of async): swagger-api/swagger-codegen#8401. Because merge and upgrade may take some time so here I send simple workaround.

Please be aware that is breaking change. API calls will have different arguments (async_req).

Before:

thread = api.create_namespaced_deployment(namespace, my_dep, async=True)

After:

thread = api.create_namespaced_deployment(namespace, my_dep, async_req=True)

Related issue: kubernetes-client/python#558

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 8, 2018
@tomplus
Copy link
Member Author

tomplus commented Jul 8, 2018

cc: @roycaihw @mbohlool

@brendandburns
Copy link
Contributor

This LGTM, @mbohlool any comments? I'll merge in 1-2 days if I don't hear anything...

@roycaihw
Copy link
Member

roycaihw commented Jul 9, 2018

/lgtm

@k8s-ci-robot
Copy link
Contributor

@roycaihw: changing LGTM is restricted to assignees, and only kubernetes-client/gen repo collaborators may be assigned issues.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yliaog
Copy link
Contributor

yliaog commented Jul 10, 2018

/lgtm

@k8s-ci-robot
Copy link
Contributor

@yliaog: changing LGTM is restricted to assignees, and only kubernetes-client/gen repo collaborators may be assigned issues.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@brendandburns brendandburns merged commit 5c23a97 into kubernetes-client:master Jul 11, 2018
gaocegege pushed a commit to kubeflow-incubator/gen that referenced this pull request Jul 18, 2018
@tomplus tomplus deleted the feat/python37 branch October 14, 2018 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants