feat: avoid creating unused ThreadPools #91
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
| @@ -82,6 +82,9 @@ if [ ${PACKAGE_NAME} == "client" ]; then | |||
| find "${OUTPUT_DIR}/client/" -type f -name \*.py -exec sed -i "s/async parameter/async_req parameter/g" {} + | |||
| find "${OUTPUT_DIR}/client/" -type f -name \*.py -exec sed -i "s/if not async/if not async_req/g" {} + | |||
|
|
|||
| # workaround https://github.com/swagger-api/swagger-codegen/pull/8061 (thread pool only on demand) | |||
There was a problem hiding this comment.
Can you add TODO: Remove this when above merges (and below too)
|
Man, I really don't love this, but forward progress is worthwhile I suppose. We're not going to be able to sustain carrying lots of patches like this... |
|
@brendandburns I couldn't agree more. It's extremely hard to maintain scripts. I've created an issue to discuss another idea #93 |
|
/lgtm I'd like us to move to openapi-codegen asap... Thanks! |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, tomplus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This version [0] makes the adal package optional [1], which also removes its dependency on the cryptography package. It also fixes a thread pool issue [2] allowing us to remove the workaround we had in place. [0]: https://github.com/kubernetes-client/python/blob/master/CHANGELOG.md#v900 [1]: kubernetes-client/python-base#108 [2]: kubernetes-client/gen#91 Change-Id: I55aa8b97483b118fbde7e11df817ad8330da9bf1
I port this PR swagger-api/swagger-codegen#8061 from swagger-codegen as a patch. This PR has approvals but swagger-codegen is not maintained regularly and we don't know when it will be merged, if at all.
It solves or mitigates these issues:
kubernetes-client/python#545
kubernetes-client/python#411
kubernetes-client/python#566
tomplus/kubernetes_asyncio#52
Thank you.
cc: @roycaihw