Skip to content
This repository has been archived by the owner on Mar 13, 2022. It is now read-only.

Fix stream decode error #130

Closed
wants to merge 1 commit into from

Conversation

leavest
Copy link

@leavest leavest commented Apr 20, 2019

Fix #88 .
#104 and #112 fix the same bug.
I work well with is.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 20, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: leavest
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: roycaihw

If they are not already assigned, you can assign the PR to them by writing /assign @roycaihw in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 20, 2019
@codecov-io
Copy link

Codecov Report

Merging #130 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #130   +/-   ##
=======================================
  Coverage   92.84%   92.84%           
=======================================
  Files          13       13           
  Lines        1328     1328           
=======================================
  Hits         1233     1233           
  Misses         95       95

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d5231c...b7efc4c. Read the comment docs.

@leavest
Copy link
Author

leavest commented Apr 20, 2019

The same bug is in kubernetes-client/python#717.
Not sure if this covers all the cases but it worked for some people.

@leavest
Copy link
Author

leavest commented Jun 15, 2019

I find bug in this code, close it

@leavest leavest closed this Jun 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stream assumes all data as UTF-8. That's not always the case.
3 participants