Skip to content
This repository has been archived by the owner on Mar 13, 2022. It is now read-only.

corrected regex to properly parse microseconds #150

Merged
merged 1 commit into from
Aug 1, 2019
Merged

corrected regex to properly parse microseconds #150

merged 1 commit into from
Aug 1, 2019

Conversation

goddenrich
Copy link
Contributor

fixes issue #149

@k8s-ci-robot
Copy link
Contributor

Welcome @goddenrich!

It looks like this is your first PR to kubernetes-client/python-base 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/python-base has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
  • Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 31, 2019
@goddenrich goddenrich changed the title corrected regex to properly parse miliseconds corrected regex to properly parse microseconds Jul 31, 2019
@yliaog
Copy link
Contributor

yliaog commented Jul 31, 2019

please sign cla

@goddenrich
Copy link
Contributor Author

please sign cla

I did before submitting pr. A little confused why its not showing up. I have signed up with the same email address as used for git commits and my full name. should the name be the username for github (ie. goddenrich)?

@codecov-io
Copy link

codecov-io commented Jul 31, 2019

Codecov Report

Merging #150 into master will increase coverage by 0.11%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #150      +/-   ##
==========================================
+ Coverage   93.44%   93.56%   +0.11%     
==========================================
  Files          13       13              
  Lines        1374     1384      +10     
==========================================
+ Hits         1284     1295      +11     
+ Misses         90       89       -1
Impacted Files Coverage Δ
config/dateutil_test.py 100% <100%> (ø) ⬆️
config/dateutil.py 95.83% <100%> (+2.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f7bcfa...ca007f3. Read the comment docs.

@goddenrich
Copy link
Contributor Author

I signed it

@micw523
Copy link
Contributor

micw523 commented Jul 31, 2019

/check-cla

@goddenrich
Copy link
Contributor Author

@yliaog I have tried everything I can with the CLA. Just raised a ticket at jira.linuxfoundation.org to try to get this resolved

@goddenrich
Copy link
Contributor Author

/check-cla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 31, 2019
@micw523
Copy link
Contributor

micw523 commented Jul 31, 2019

Okay now you're good for the CLA.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 1, 2019
@yliaog
Copy link
Contributor

yliaog commented Aug 1, 2019

thanks. please squash the commits.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 1, 2019
@k8s-ci-robot k8s-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 1, 2019
@goddenrich
Copy link
Contributor Author

I squashed commits and removed some unnecessary spaces. Thanks

@yliaog
Copy link
Contributor

yliaog commented Aug 1, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 1, 2019
@yliaog
Copy link
Contributor

yliaog commented Aug 1, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: goddenrich, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2019
@k8s-ci-robot k8s-ci-robot merged commit ec31e05 into kubernetes-client:master Aug 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants